lib/types: allow changing the name of name#218812
Closed
ncfavier wants to merge 1 commit intoNixOS:masterfrom
Closed
lib/types: allow changing the name of name#218812ncfavier wants to merge 1 commit intoNixOS:masterfrom
name#218812ncfavier wants to merge 1 commit intoNixOS:masterfrom
Conversation
Adds a new `nameArgument` argument to `submoduleWith` that allows changing which argument the "name" (last item of `loc`, i.e. attribute name or option name this submodule appears under) is bound to. This avoids conflicts when `moduleType` is used inside a submodule, where `name` would be set to both the outer submodule's name and the inner one's. If the outer submodule type sets `nameArgument` to something different, `moduleType` will continue using `name`, avoiding the conflict. Ideally, there should probably be a way to change the inner `name` too to remove all ambiguity.
2 tasks
Member
|
Duplicate of #177576, but can be considered again. |
ofborg
bot
added
10.rebuild-darwin: 0
Member
Author
|
I thought this might have been a known issue, but couldn't find it. I certainly did not expect it to have been known for 9 years 😅. Since much better solutions are being discussed ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides a way to fïx nix-community/home-manager#3716
Adds a new
nameArgumentargument tosubmoduleWiththat allows changing which argument the "name" (last item ofloc, i.e. attribute name or option name this submodule appears under) is bound to.This avoids conflicts when
moduleTypeis used inside a submodule, wherenamewould be set to both the outer submodule's name and the inner one's. If the outer submodule type setsnameArgumentto something different,moduleTypewill continue usingname, avoiding the conflict.Ideally, there should probably be a way to change the inner
nametoo to remove all ambiguity.